-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Delay start of email inbox #23521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this combination startup + defer makes sense, if you need some "delay" to solve some race condition or something I'm quite sure we can find a better way
Meteor.defer(() => { | ||
configureEmailInboxes(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the point doing this? what does this actually fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the issue with this one is that the email inbox depends on a setting being set (Routing_algo). Since the inbox can receive emails before the setting is set (because the setting now runs on a meteor startup) this was aiming to delay the execution of that inbox configuration (there is a task to replace this with a setting watch or another kind of delay too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed there's a watchOnce
now for settings, I'll use it and change this to that 👀
and please check if you can #22588 |
Oh, I didn't know this feature affected the other (didn't know the other existed tho) I'll take a look at it later 👀 |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments